Harden WaterWorld input dimensions - #81
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
krotname
deleted the
codex/fix-unchecked-dimension-vulnerability-in-waterworld
branch
August 1, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
NegativeArraySizeException,ArrayIndexOutOfBoundsException, orOutOfMemoryErrorwhen allocating the map or BFS queue.Description
checkedTotalCells(n, m)with aMAX_CELLSlimit and uselongmultiplication to detect overflow and overly large maps, and throwIllegalArgumentExceptionfor invalid sizes.solveandrun, and checkmap.lengthconsistency before allocating the BFS queue.FastIn.nextInt()to reject non-digit characters and detect integer overflow while parsing, throwingIOExceptionfor invalid tokens.run()invocation inmainwith atry/catchthat ignoresIllegalArgumentExceptionandIOExceptionso invalid input is rejected gracefully without performing large allocations.Testing
javac -d /tmp/classes src/main/java/algorithms/sprint6/WaterWorld.javaand compilation succeeded.printf '3 3\n#.#\n.#.\n#.#\n' | java -cp /tmp/classes algorithms.sprint6.WaterWorldwhich produced the expected output.printf '50000 50000\n' | java -cp /tmp/classes algorithms.sprint6.WaterWorldandprintf '2147483648 1\n' | java -cp /tmp/classes algorithms.sprint6.WaterWorld, both of which no longer trigger allocation crashes.mvn test(initial run failed due to a transient Maven Central502 Bad Gatewaywhile resolving a dependency) and then retriedmvn -q test, which completed (transient network failure noted).Codex Task